Vestige module is not listed despite it builds successfully

[ClockGen]

I'm using arch linux x64. I'm trying to get lmms version with vestige module, but it doesn't show up.
I have all deps installed, when running cmake, it states that both vst instrument and vst effect are ok, also I see that everything related to vst compiled and linked successfully, but when I'm opening lmms itself, vestige module is not listed on the list. Compiling with gcc 5.3.0.

Edit: @tresf from conversation on #lmms after adding qDebug()

"Cannot load library /home/tricobalt/lmms/build/plugins/libvestige.so: (../libvstbase.so: cannot open shared object file: No such file or directory)"
"Cannot load library /home/tricobalt/lmms/build/plugins/libvsteffect.so: (../libvstbase.so: cannot open shared object file: No such file or directory)"

[tresf]

@Bukarus it looks like we're never displaying library load errors from our plugins directory.

For troubleshooting, can you please add this to PluginFactory.cpp#147

PluginFactory.cpp#L147

qWarning() << library->errorString();

This will tell us what the error message is while loading. For example, if I make a fake plugin:

touch plugins/libFake.so

Then I get the following output in console:

"Cannot load library /home/foo/lmms/build/plugins/libFake.so: 
(/home/foo/lmms/build/plugins/libFake.so: invalid ELF header)"

FYI - Not sure how much success you'll have once this bug is closed due to #1875, but we should be able to fix the linking problem. 👍

[tresf]

@lukas-w should we add some debug info to the console for cases like this? It seems quite strange that we offer no output when a lib fails to load, especially libs that are placed into the /plugins directory.

[tresf]

Ok... perhaps new cmake CMP0015 behavior going on here...

What cmake version are you on?

@Bukarus can you add this to /CMakeLists.txt#L11 and see if it fixes it?

IF(COMMAND CMAKE_POLICY)
    CMAKE_POLICY(SET CMP0005 NEW)
    CMAKE_POLICY(SET CMP0003 NEW)
    IF (CMAKE_MAJOR_VERSION GREATER 2)
+       CMAKE_POLICY(SET CMP0015 OLD)
        CMAKE_POLICY(SET CMP0026 OLD)
    ENDIF()
ENDIF(COMMAND CMAKE_POLICY)

[ClockGen]

Putting libvestige.so to build's parent directory (root of the entire lmms folder) makes vestige appear on the list. Compiling with modified cmakelists (and clean lmms repo clone) didn't make any difference, though.

[tresf]

Ok... I think this is a duplicate of #2572.

The relevant portion is here:

... [foo.so] is compiled as a module and not as a shared library (maybe a change in cmake cause this - cmake 3.4.1 ...).

The solution would be similar to pulls/#2758, scroll down to the CMakeLists.txt portion.

If this is correct, we'll need to fix it for plugins/vestige/CMakeLists.txt as well as plugins/VstEffect/CMakeLists.txt too.

If you can please test this out and get back to us, we can have a patch submitted right away.

[liushuyu]

The solution would be similar to pulls/#2758, scroll down to the CMakeLists.txt portion.

Yes, I also uses Arch Linux x86_64 version, and this surely worked for me.

[tresf]

@liushuyu can you please fork and pull request this change or post the diff so that one of us can implement it? I assume #1875 is still broken afterward, right?

[ClockGen]

@tresf could you give me instructions how to fix vestige and vsteffects cmakefiles.txt, so I could check if #1875 still happens?

[tresf]

@tresf could you give me instructions how to fix vestige and vsteffects cmakefiles.txt, so I could check if #1875 still happens?

I was hoping @liushuyu would do that. I don't have a machine ready to test the code on, wherease @liushuyu apparently does. 👍

[tresf]

@tresf could you give me instructions how to fix vestige and vsteffects cmakefiles.txt, so I could check if #1875 still happens?

If I were to try, I'd start by adding this line to the plugins/vestige/CMakeLists.txt file. 👍

If that fixes the listing, I'd repeat for the VstEffects, respectively.

[lukas-w]

@lukas-w should we add some debug info to the console for cases like this?

Yes! It'd be helpful to have an output in the GUI as well but that's an ongoing discussion iirc (about how to do this while keeping engine and gui decoupled).

[tresf]

Yes! It'd be helpful to have a output in the GUI as well but that's an ongoing discussion iirc (about how to do this while keeping engine and gui decoupled).

They're being collected alright, not sure how best to log them (#1945, #1525, @Wallacoloo), nor where they're going #1524...

[liushuyu]

I was hoping @liushuyu would do that. I don't have a machine ready to test the code on, wherease @liushuyu apparently does.

First, yes you are right. 😀
so how to fix?
Just take a look at #2578, I found the same solution can be applied to Vestige compilation ('Linking', more precisely).
What's more, I even tried to change the link method to 'SHARED' of all the plugins, and expect a crash. But to my 'surprise', LMMS still worked like a charm. XD

So just change the link method of Vestige from "MODULE" to "SHARED" will work ( I swear...)

[liushuyu]

@liushuyu can you please fork and pull request this change or post the diff so that one of us can implement it? I assume #1875 is still broken afterward, right?

Yes, #1875 still exists... It takes forever to load the VST plugins under Arch Linux 64-bit (Other platforms have not tested, and I am afraid this could likely to happen on many 64-bit Linux systems) . 🌝

[tresf]

A Pull Request would be fantastic from someone who's already working on this code (including both vestige and VstEffects confirmed on a platform exhibiting the issues. If not, we'll get to it... eventually.

[tresf]

@lukas-w your auto-assign stuff, please turn it off. 👍 😄

[tresf]

@Bukarus, fixed. Please issue a git pull and you'll have the fix implemented.

@liushuyu much obliged. 🌝

[lukas-w]

your auto-assign stuff, please turn it off.

Is it still doing that? I'll try, but I'll probably have to reach out to support… Should be turned off now.

[tresf]

Is this "reviewable" crane/weird purple bird looking thing your doing as well? #2632 (comment) 😆 Killing off github access should do it. There should be a way un-trust the service.

[lukas-w]

No, it isn't. Promise 🙌