-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1426 from LMMS/ed_refac
Editor Refactoring
- Loading branch information
Showing
72 changed files
with
2,481 additions
and
2,542 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Editor.h - declaration of Editor class | ||
* | ||
* Copyright (c) 2014 Lukas W <lukaswhl/at/gmail.com> | ||
* | ||
* This file is part of LMMS - http://lmms.io | ||
* | ||
* This program is free software; you can redistribute it and/or | ||
* modify it under the terms of the GNU General Public | ||
* License as published by the Free Software Foundation; either | ||
* version 2 of the License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
* General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public | ||
* License along with this program (see COPYING); if not, write to the | ||
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, | ||
* Boston, MA 02110-1301 USA. | ||
* | ||
*/ | ||
|
||
|
||
#ifndef ACTION_GROUP_H | ||
#define ACTION_GROUP_H | ||
|
||
#include <QActionGroup> | ||
|
||
/// \brief Convenience subclass of QActionGroup | ||
/// | ||
/// This class provides the same functionality as QActionGroup, but in addition | ||
/// has the actionTriggered(int) signal. | ||
/// It also sets every added action's checkable property to true. | ||
class ActionGroup : public QActionGroup | ||
{ | ||
Q_OBJECT | ||
public: | ||
ActionGroup(QObject* parent); | ||
|
||
QAction* addAction(QAction *a); | ||
QAction* addAction(const QString &text); | ||
QAction* addAction(const QIcon &icon, const QString &text); | ||
|
||
signals: | ||
/// This signal is emitted when the action at the given index is triggered. | ||
void triggered(int index); | ||
|
||
private slots: | ||
void actionTriggered_(QAction* action); | ||
|
||
private: | ||
QList<QAction*> m_actions; | ||
}; | ||
|
||
#endif |
Oops, something went wrong.
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automation editor doesn't work now. Shows only a blank window. Can you fix this?
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't experience this, what are your exact steps?
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukas-w this happens:
Object::connect: No such slot AutomationPattern::openInAutomationEditor()
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exact steps: compile latest master, start a new project, try to create a new automation pattern and open it in automation editor, results in blank window. See also above error message. Maybe you've renamed a slot and forgot to change a connect() call?
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using the context menu for opening the pattern or are you double clicking?
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I removed the
openInAutomationEditor()
function, and seemed to miss the call in the context menu.384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
384a48f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done ;) 30bc86e