Fix locale dependent delay names #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The technical names and display names of the delays are generated via `sprintf` calls which are locale dependent. This means that for example the feedback delay might be saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma). The fix adds a string array next to the array of lengths and uses this string array when creating the names. This ensures that they will not be locale dependent and that they will always look the same.
This was referenced Apr 13, 2024
messmerd
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The technical names and display names of the delays are generated via
sprintfcalls which are locale dependent. This means that for example the feedback delay might be saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma).The fix adds a string array next to the array of lengths and uses this string array when creating the names. This ensures that they will not be locale dependent and that they will always look the same. Because the names are English anyway the point was chosen as the decimal separator.
Partially fixes LMMS issue 5167.