[FEAT]: Alt+Tabbing to a window obscured by the monocle should disable monocle and focus the alt+tabbed window #834
Comments
|
This is possible to implement, but doing so would break the ability to focus left/right to a different monitor while in monocle mode (monocle mode would be toggled off) Unfortunately Windows does not send a unique event for focus via alt-tab, so all event where a window is shown on a workspace either via the focus command or via alt-tab would toggle off monocle mode ^ |
|
Actually, this behaviour above is already broken ^ 🤔 |
|
I'm a little confused. Which behavior is the broken one? |
This is broken for me on master, taking a look now |
This commit adds a change to automatically toggle monocle mode off on the focused workspace when a window on the same workspace is foregrounded by alt-tab. resolve #834
|
Need to get some more feedback on this: 57825db The only way this can work is if the monocle state doesn't persist across workspace transitions |
|
Hmm... I would personally prefer the existing behavior then..... Also, coming from a very naive point of view, would it be a lot of work to implement a replacement for the alt tab window that behaves and sends the unique Id needed? |
This commit ensures that horizontal focus moves onto other monitors from a monocle container are respected (ie. we don't try moving left/right within the workspace on the focused monitor). Additionally, if the user tries to alt-tab a window to the foreground on a workspace where a monocle container exists, the window will flash before being hidden behind the monocle container as a visual cue that monocle mode needs to be disabled to access that window. This is in contrast to the current behaviour where that window floats on top of the monocle container in a somewhat broken state. re #834
|
I have fixed the horizontal focus moves towards other monitors from a monocle container. Regarding the alt-tab behaviour, for now I have settled to let an alt-tabbed window flash above a monocle container briefly before being hidden again, instead of having it stay on top in a somewhat broken visual state. For an alt-tab replacement, I think it is possible, and if someone wanted to build that it would be possible to integrate it with komorebi's state via the |
|
Thanks a lot! |
|
What would be your advice regarding the alt-tab switcher as a project for a beginner who has just finished the cs50 course and who is just starting to learn rust via the rust book. Is it too advanced of a project or would it be doable? |
|
I found this https://github.com/ike9000e/Classic-AltTab That I thought I could maybe port to rust as a learning project and integrate with komorebi. |
|
Also I'm making a feedback post regarding the need for a better virtual desktops api on the windows feedback app. |
|
Found another bug, Closing a monocled window via clicking the close button or Alt+F4 results in a blank monocle which then has to be exited using the toggle monocle keyboard shortcut. |
This commit fixes a regression introduced by hiding other containers when monocle is enabled. When the monocle container is closed, other containers on the workspace will now be restored. re #834
Is your feature request related to a problem? Please describe.
Alt tabbing to a window obscured by the monocle takes you to the monocle frame, but does not reveal it.
Describe the solution you'd like
Alt+Tabbing to a window obscured by the monocle should disable monocle and focus the alt+tabbed window
The text was updated successfully, but these errors were encountered: