Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas estimation factor #514

Merged

Conversation

annamcallister
Copy link
Contributor

@annamcallister annamcallister commented Jan 15, 2025

Follow on to #508

Discussed with Cheng who confirmed that

  • best practice is to explicitly set a gas limit on a transaction rather than use an estimate
  • the default factor for firefly is 1.5 - we see no reason why there should be a difference between the projects

We also agreed that it would be ideal for the quickstart to have a higher factor, since we know that

  • this is a gas free chain
  • even simple contracts can require more than an additional 50% on top of the estimated value
  • early success using this out of the box setup is important

(also included some comment fixes to a yaml file)

Copy link
Contributor

@hosie hosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwertent dwertent enabled auto-merge January 15, 2025 19:19
@dwertent dwertent disabled auto-merge January 15, 2025 19:19
@dwertent dwertent enabled auto-merge January 15, 2025 19:20
@dwertent dwertent merged commit bf09215 into LF-Decentralized-Trust-labs:main Jan 15, 2025
6 checks passed
@annamcallister annamcallister deleted the gas-estimation-factor branch January 16, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants