Fix chart installation #401
Conversation
dwertent
commented
Nov 6, 2024
dwertent
commented
- Adjust template placeholder decoding.
- Enable replacement of the paladin image in the values file.
- Remove cert-manager from the chart dependencies.
Signed-off-by: dwertent <[email protected]>
Signed-off-by: dwertent <[email protected]>
Signed-off-by: dwertent <[email protected]>
| @@ -914,7 +915,7 @@ issuerRef: | |||
| if tlsConf.CertSpecTemplate != "" { | |||
| specTemplate = tlsConf.CertSpecTemplate | |||
| } | |||
| template, err := template.New("").Option("missingkey=error").Funcs(sprig.FuncMap()).Parse(specTemplate) | |||
| template, err := template.New("").Option("missingkey=error").Funcs(sprig.FuncMap()).Parse(adjustTemplatePlaceholders(specTemplate)) | |||
There was a problem hiding this comment.
I'm sorry @dwertent, I feel a little lost to understand why there's a codechange in the Operator (rather than the generation of the CRs). Going to see if I can understand by building the Helm charts to see what's inside of them.
I assert that from the Operator's perspective, the YAML should be valid. It should contain a valid Go template (or if we don't like go templates, we use a different Template engine like yq etc.).
The the thing generating the YAML needs to have templating itself, like Helm, then it's responsible for doing the right escaping in the Helm chart to make the result of the helm chart valid YAML-containing-a-go-tempalte.
There was a problem hiding this comment.
I generated the helm chart, and the values I thought would be problematic look fine to me
"implementation": '{{`{{ index .status.resolvedContractAddresses "zeto-impl-anon" }}`}}',
^^^ looks like should generate the right CR per Helm escaping rules... going to try and see if I can recreate a problem with this
There was a problem hiding this comment.
Ok - I think I understood what was being attempted here, and I don't think it was quite right to do it in the operator and handle bad templates generated by the helm charts.
We have two types of things:
- YAML samples
- Helm templates
We want to take our YAML samples, and turn them into HELM templates.
We do that in:
make prepare-operator-chartSo I have fixed that Makefile thing to escape the {{ characters.
Given it was Makefile code, the thing I had to hand to do this was sed.
We could move this to Gradle, and then we could use nicer tools. But I didn't have time today.
Lines 203 to 211 in fb4fa83
