Pick nodes consistently in "npm run dev", and query fixes #394
Conversation
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
| errorMsg: string, | ||
| ignoreStatuses: number[] = [] | ||
| ) => { | ||
| const res = await resFn(); |
There was a problem hiding this comment.
I think this was the key fix - that resFn wasn't being await'ed in the previous param structure of returnResponse
| } catch { | ||
| return {}; | ||
| } | ||
| return (await res.json()).result; |
There was a problem hiding this comment.
The original goal of this try catch was to quietly handle cases where the value returned is not a valid JSON. Note that with this change we assume the response will always be a valid JSON.
There was a problem hiding this comment.
Very helpful to have that - I couldn't work that out from the code alone, as it seemed to be deliberately translating errors in a success payload. I thought that was the intent of the code.
A note that I didn't see a change / comments / intent described in the changes under #399, so if you have more updates to make a single approach to the different types of errors coming back to the UI true, that would be great.
The "error" categories include:
- Something that isn't JSON/RPC came back - like a
504gateway error, which won't be JSON parsable - An error specific to a JSON/RPC call came back, with an error code, which could be displayed to a user
- An error specific to a JSON/RPC call came back, which in that particular case the UI wants to hide from the user (like the fact there is no domain receipt on the node)
nullcame back from a query describing a straight forward not found scenario
Signed-off-by: Gabriel Indik <[email protected]>
Further UI improvements
Proposed changes
Enhancements to:
npm run devthatnodeis on 3000