Add basic TypeScript example app #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
peterbroadhurst
approved these changes
Nov 5, 2024
| @@ -135,6 +136,10 @@ func (tm *txManager) WritePreparedTransactions(ctx context.Context, dbTX *gorm.D | |||
|
|
|||
| if len(preparedTxInserts) > 0 { | |||
| err = dbTX.WithContext(ctx). | |||
| Clauses(clause.OnConflict{ | |||
There was a problem hiding this comment.
Thanks for catching this on the way 👍
The delivery semantic is at least once, so this makes sense.
example/bond/scripts/abi.mjs
Outdated
There was a problem hiding this comment.
Very glad you did a NPM version of this, rather than requiring users to need gradle to run the samples 👍
... I do think though this won't have run the actual build. But an NPM user will probably be happy to just run npx hardhat build in the solidity project.
There was a problem hiding this comment.
Yes, the README lays out the minimum steps, all of which can be done with just npm (in the solidity folder and then here).
sdk/typescript/src/README.md
Outdated
There was a problem hiding this comment.
Brilliant to see the starting point on this 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.