Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change RawBytesOffsets into a validated newtype #137

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jan 22, 2025

Closes #132

@LDeakin LDeakin added the breaking-changes The PR has API changes label Jan 22, 2025
@LDeakin LDeakin added this to the zarrs 0.20 milestone Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (091019b) to head (4b42192).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   81.90%   81.92%   +0.01%     
==========================================
  Files         172      173       +1     
  Lines       24340    24411      +71     
==========================================
+ Hits        19936    19998      +62     
- Misses       4404     4413       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit 177f701 into main Jan 22, 2025
22 checks passed
@LDeakin LDeakin deleted the offsets_newtype branch January 22, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes The PR has API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a validated newtype for RawBytesOffsets
1 participant