Update/analysis improvements #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of analysis to close view erroneously
jnation3406
approved these changes
Jan 29, 2025
| @@ -207,26 +211,10 @@ function showHeaderDialog() { | |||
| </v-dialog> | |||
| <v-dialog | |||
| v-model="headerDialog" | |||
| width="auto" | |||
| width="600px" | |||
There was a problem hiding this comment.
Is this specific width gonna work okay on different sized screens vs auto? I do this too by the way since I don't know how to make things work without fixed sizes sometimes.
There was a problem hiding this comment.
yeah this was just so it wouldn't keep resizing all over the place. Iphone dimensions are generally ~1200px wide by ~2600 pixels tall, so it should still be able to fit well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Couple of bug fixes, changes, and imrpovements I've been wanting to add to the analysis page.
Changes
Example of previous image fitting
Screen.Recording.2025-01-28.at.4.06.46.PM.mov
Example of new image fitting
Screen.Recording.2025-01-28.at.4.03.01.PM.mov
Searchable fits headers
