Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics.py: fix compatibility with scipy >=1.13 #344

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mattpitkin
Copy link
Contributor

As of scipy v1.13, the hann window has been removed from scipy.signals and is now only accessible through scipy.signals.windows. This PR accounts for this move so that pyroomacoustics will work with the latest scipy versions.

Closes #342

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR 😃

@GaetanLepage
Copy link

Thank you for this fix. Using pyroomacoustics with the latest scipy is indeed broken.

@fakufaku
Copy link
Collaborator

@mattpitkin Thank you so much for taking care of this. LGTM

@fakufaku fakufaku merged commit e753328 into LCAV:master Apr 23, 2024
5 of 13 checks passed
@mattpitkin mattpitkin deleted the scipy_1.13_compatible branch April 23, 2024 06:17
@GaetanLepage
Copy link

Thanks for the fix ! @fakufaku could you please consider making a release for this fix to be available to a broader audience ?

@fakufaku
Copy link
Collaborator

@GaetanLepage Yes of course! I am working on this right now.

@fakufaku
Copy link
Collaborator

@mattpitkin v0.7.4 is out! Thanks for the contribution!

@mattpitkin
Copy link
Contributor Author

Cool. Glad to be of help.

Just a quick note to say that the date for the new release in the changelog file needs to be updated!

@fakufaku
Copy link
Collaborator

Just a quick note to say that the date for the new release in the changelog file needs to be updated!

Oups!! Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scipy.signal.hann is deprecated in SciPy 1.13.0
3 participants