metrics.py: fix compatibility with scipy >=1.13 #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of scipy v1.13, the
hann
window has been removed fromscipy.signals
and is now only accessible throughscipy.signals.windows
. This PR accounts for this move so that pyroomacoustics will work with the latest scipy versions.Closes #342
nosetests
orpy.test
at the root of the repo ?Happy PR 😃