Colatitude calculation fix #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing parenthesis and adjusted the tests
fakufaku
added a commit
that referenced
this pull request
Nov 25, 2023
* Fixes a bug in the angle_function for azimuth/colatitude computation (initial PR #329) --------- Co-authored-by: Fabio Di Marco <[email protected]>
|
Thanks for finding this bug, this is a nasty one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update fixed the colatitude calculation. A missing parenthesis was added, and the associated tests were adjusted accordingly.
Code Change
Previous Code:
Updated Code:
Implications
The absence of parenthesis around
1 / 2led to miscalculations of the colatitude angle. This is particularly relevant in simulations involving Cardioid or Hypercardioid microphones or in case of directional sources.