Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure eval subset is sampled without replacing #3651

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Make sure eval subset is sampled without replacing #3651

merged 1 commit into from
Aug 14, 2023

Conversation

andreaskoepf
Copy link
Collaborator

Explicitly specify replace=False for numpy.random.choice (it was missing and default is replace=True which could lead to duplicate examples in the evaluation set).

shahules786
shahules786 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@shahules786 shahules786 merged commit 90e442a into main Aug 14, 2023
@shahules786 shahules786 deleted the fix_max_eval_sampling branch August 14, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahules786 shahules786 shahules786 approved these changes

@theblackcat102 theblackcat102 Awaiting requested review from theblackcat102 theblackcat102 is a code owner

@sanagno sanagno Awaiting requested review from sanagno sanagno is a code owner

@dvruette dvruette Awaiting requested review from dvruette dvruette is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@jordiclive jordiclive Awaiting requested review from jordiclive jordiclive is a code owner

Assignees
No one assigned
Labels
ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaskoepf @shahules786