Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make send report message from discord a celery task. #3089

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Make send report message from discord a celery task. #3089

merged 10 commits into from
Jun 14, 2023

Conversation

espoirMur
Copy link
Contributor

Fixes #2992

@espoirMur espoirMur marked this pull request as draft May 8, 2023 13:50
@github-actions
Copy link

github-actions bot commented May 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

github-actions bot commented May 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

github-actions bot commented May 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@espoirMur
Copy link
Contributor Author

I have done most of what was required for the ticket.. the next step will be how to test if this is working.

If anyone has idea on how to test this, please do let me know.. @olliestanley

@olliestanley
Copy link
Collaborator

I have done most of what was required for the ticket.. the next step will be how to test if this is working.

If anyone has idea on how to test this, please do let me know.. @olliestanley

If you run docker compose --profile ci up --build --attach-dependencies it will run the backend and website locally including the changes you have made. You can use this for testing. Alternatively you could run the services separately

@espoirMur espoirMur marked this pull request as ready for review May 8, 2023 18:05
@github-actions
Copy link

github-actions bot commented May 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

olliestanley
olliestanley reviewed May 8, 2023
View reviewed changes
.python-version Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
backend/oasst_backend/prompt_repository.py Outdated Show resolved Hide resolved
backend/oasst_backend/scheduled_tasks.py Outdated Show resolved Hide resolved
backend/requirements.txt Show resolved Hide resolved
backend/requirements_worker.txt Show resolved Hide resolved
docker-compose.yaml
@@ -117,7 +117,7 @@ services:
build:
dockerfile: docker/Dockerfile.backend-worker
context: .
command: celery -A oasst_backend.celery_worker worker -l info
command: celery -A oasst_backend.celery_worker worker -l info -E
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the -E flag for here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -E flag hel to list all the task in the worker

backend/oasst_backend/prompt_repository.py Show resolved Hide resolved
backend/.env.example Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andreaskoepf
Copy link
Collaborator

@espoirMur could you resolve the conflicts please?

andreaskoepf
andreaskoepf approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, also for cleanup of readme! :-)

@andreaskoepf andreaskoepf merged commit 5e51e7b into LAION-AI:main Jun 14, 2023
@espoirMur espoirMur deleted the espoir-playground branch June 15, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliestanley olliestanley olliestanley left review comments

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@melvinebenezer melvinebenezer Awaiting requested review from melvinebenezer melvinebenezer is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate flagged message Discord notifications to Celery task
3 participants
@espoirMur @olliestanley @andreaskoepf