Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use prefix with etag middleware #227

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

Krukov
Copy link
Owner

@Krukov Krukov commented May 12, 2024

Fix for #218

@Krukov Krukov force-pushed the fix/use-prefix-with-etag branch from 37d573c to a5986e3 Compare May 12, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.76%. Comparing base (c2d7e32) to head (b0364e6).
Report is 2 commits behind head on master.

Files Patch % Lines
cashews/contrib/fastapi.py 90.00% 2 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   93.79%   93.76%   -0.04%     
==========================================
  Files          54       54              
  Lines        3498     3496       -2     
  Branches      604      604              
==========================================
- Hits         3281     3278       -3     
- Misses        108      109       +1     
  Partials      109      109              
Flag Coverage Δ
unittests 93.64% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krukov Krukov force-pushed the fix/use-prefix-with-etag branch 2 times, most recently from c1450ee to a582f3b Compare May 12, 2024 09:32
@Krukov Krukov force-pushed the fix/use-prefix-with-etag branch from a582f3b to b0364e6 Compare May 12, 2024 09:34
@Krukov Krukov merged commit bd70993 into master May 12, 2024
6 checks passed
@Krukov Krukov deleted the fix/use-prefix-with-etag branch November 30, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants