Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use early ttl with early cache in etag middleware #217

Merged
merged 1 commit into from
May 5, 2024

Conversation

Krukov
Copy link
Owner

@Krukov Krukov commented May 5, 2024

fix #202

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.78%. Comparing base (bf31f06) to head (ed3b749).

Files Patch % Lines
cashews/contrib/fastapi.py 70.00% 2 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   94.08%   93.78%   -0.30%     
==========================================
  Files          54       54              
  Lines        3483     3493      +10     
  Branches      602      605       +3     
==========================================
- Hits         3277     3276       -1     
- Misses        101      108       +7     
- Partials      105      109       +4     
Flag Coverage Δ
unittests 93.67% <65.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krukov Krukov force-pushed the fix/etag-for-early-cache branch from 8c969e3 to ed3b749 Compare May 5, 2024 18:02
@Krukov Krukov merged commit 6ddbaae into master May 5, 2024
6 of 8 checks passed
@Krukov Krukov deleted the fix/etag-for-early-cache branch November 30, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

early_ttl not working in combination with CacheEtagMiddleware
2 participants