Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current implementation of thunder_protection may cause "Future exception was never retrieved" warning #144

Closed
Rebzzel opened this issue May 30, 2023 · 1 comment
Closed

Current implementation of thunder_protection may cause "Future exception was never retrieved" warning #144

Rebzzel opened this issue May 30, 2023 · 1 comment

Comments

@Rebzzel
Copy link
Contributor

Rebzzel commented May 30, 2023

Due to:

cashews/cashews/decorators/locked.py

Line 91 in c02c3b6

del futures[_key]

If it has never been called:

cashews/cashews/decorators/locked.py

Line 97 in c02c3b6

return await futures[_key]

Rebzzel added a commit to Rebzzel/cashews that referenced this issue May 30, 2023
@Rebzzel
fix: future exception never retrived problem (Krukov#144)
96445e5
@Krukov
Copy link
Owner

Krukov commented May 31, 2023 •
edited
Loading

thanks for reporting and fix for this issue. PR just merged. I gonna release it soon with other changes

@Krukov Krukov closed this as completed May 31, 2023
Krukov added a commit that referenced this issue May 31, 2023
@Krukov
Merge pull request #145 from Rebzzel/master
8b28d8c 
fix: future exception never retrived problem (#144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Krukov @Rebzzel