Simplify Setup for a Django Project #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for unsupported Django versions 1.4-1.7
for monitoring code coverage
so that additions to the dict do not require changes to an irrelevant line
so that the given views can be used directly
by allowing subclasses to provide the nameid attribute and provide additional setup for new users (ie. set privileges)
|
There is no logout view? |
|
That's right, a logout view is not provided because |
|
Woah nice PRs @RevolutionTech, check out https://github.com/python-security/pyt sometime ;) |
|
👍 To merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #11.
This PR also simplifies the setup and integration of
django-saml-service-providerinto a Django project by allowing settings insettings.pyto be configured making the views insaml_service_provider.viewsusable without the user having to create their own views.It also makes the provided auth backend more flexible and extensible, without having to override the entire
authenticate()method for most use cases.This PR also allows first and last names to be missing from the SAML response, and updates user attributes on every sign-in, instead of just when creating the user.