[GeoMechanicsApplication] Made input providers of the calculators structs and remove redundant getters #13156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logic, to remove redundant getters
markelov208
approved these changes
Feb 21, 2025
avdg81
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
I completely agree with @markelov208: thank you for your continuous efforts to improve the code. This is a good example of it. I have no questions or suggestions, so feel free to merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small clean-up: since the input providers only contain (the functions to obtain) data, a
structis more suitable. This also reduces the code, since we don't need the getters anymore.