Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluidDynamicsApplication] Virtualize calculateall of stokes_3D_twofluid #13155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pablobecker
Copy link
Member

📝 Description
adds virtual to CalculateAll to allow override in derived class

Please mark the PR with appropriate tags:

  • Api Breaker, Mpi, etc...

🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.

  • Added virtual to CalculateAll

@pablobecker pablobecker added FastPR This Pr is simple and / or has been already tested and the revision should be fast FluidDynamics labels Feb 20, 2025
@pablobecker pablobecker self-assigned this Feb 20, 2025
@pablobecker pablobecker requested a review from a team as a code owner February 20, 2025 15:47
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablobecker
Copy link
Member Author

ping @rubenzorrilla is it ok for you?

@rubenzorrilla
Copy link
Member

Sure. The point is that I thought that there were no uses of this element. I guess you're still using it right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast FluidDynamics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants