[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme #13152

rfaasse · 2025-02-20T13:11:11Z

📝 Description
In our workflows which include deactivations + structural elements, we have encountered issues with initialization of inactive elements. This will be fixed in core as well, but until that is done, this temporary fix in the geomechanics time integration scheme is done. Also tests are added (integration + unit), such that we can verify this behavior, also when the fix is done in core and the change in the geomechanics time integration scheme can be reverted.

…e truss

…esults

avdg81

Yet another step towards being able to simulate the quay wall model using the build from master. Thank you for the clear fix and the well-documented test. I have a few questions and suggestions. Hope this helps.

avdg81 · 2025-02-21T09:29:40Z

...sApplication/tests/cpp_tests/custom_strategies/test_geomechanics_time_integration_scheme.cpp

@@ -53,8 +53,10 @@ class GeoMechanicsSchemeTester
        mModel.CreateModelPart("dummy", 2);
    }

-    template <class T>
-    void TestFunctionCalledOnComponent_IsCalledOnActiveAndInactiveComponents()
+    template <class T, typename AddComponentToModelPartLambda>


Perhaps we can make this type name slightly more general? For instance:

Suggested change

template <class T, typename AddComponentToModelPartLambda>

template <typename T, typename AddComponentToModelPartCallable>

avdg81 · 2025-02-21T09:55:18Z

...sApplication/tests/cpp_tests/custom_strategies/test_geomechanics_time_integration_scheme.cpp

 }

-KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveElements, KratosGeoMechanicsFastSuiteWithoutKernel)
+KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveConditions,


"Conditions" should be "Elements":

Suggested change

KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveConditions,

KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveElements,

avdg81 · 2025-02-21T10:19:25Z

applications/GeoMechanicsApplication/tests/deactivation_with_structural_element/Materials.json

+                "K0_MAIN_DIRECTION"             : 1,
+                "K0_NC"                         : 0.5


I believe the K0 procedure parameters are redundant here, since we don't apply the K0 procedure.

You're right, removed 👍

avdg81 · 2025-02-21T12:13:47Z

...echanicsApplication/tests/deactivation_with_structural_element/ProjectParameters_stage2.json

+                "value":           [10000,0.0]
+            }
+        }],
+        "list_other_processes"     : []


I think we can get rid of this empty list.

avdg81 · 2025-02-21T12:15:27Z

...echanicsApplication/tests/deactivation_with_structural_element/ProjectParameters_stage2.json

+                "value"           : [0.0,0.0,0.0],
+                "table"           : [0,0,0]
+            }
+        },{


Is there any reason why in the second stage the horizontal displacements of all nodes are no longer constrained?

The reason is an oversight from my side, corrected it now, good catch!

avdg81 · 2025-02-21T12:16:38Z

...echanicsApplication/tests/deactivation_with_structural_element/ProjectParameters_stage2.json

+        "reduction_factor"                   : 0.5,
+        "increase_factor"                    : 2.0,
+        "desired_iterations"                 : 4,
+        "calculate_reactions"                : true,


In stage 1, this flag was set to false, now it is true. Can you help me to understand why?

No, I wanted to calculate as little as possible so put it to false in stage 1, but forgot stage 2. Made it more consistent now

avdg81 · 2025-02-21T12:23:12Z

applications/GeoMechanicsApplication/tests/test_deactivation_with_structural_element.py

+
+        file_pattern = os.path.join(project_path, "ProjectParameters_stage*.json")
+        stage_files = glob.glob(file_pattern)
+        print(stage_files)


This seems to be intended for debugging. I'd suggest to remove it.

…emoving SQ code smells

rfaasse

Processed the review comments, fixed SQ issues and did some formatting on the python file

rfaasse · 2025-02-21T12:40:56Z

applications/GeoMechanicsApplication/tests/deactivation_with_structural_element/Materials.json

+                "K0_MAIN_DIRECTION"             : 1,
+                "K0_NC"                         : 0.5


You're right, removed 👍

rfaasse · 2025-02-21T12:44:42Z

...echanicsApplication/tests/deactivation_with_structural_element/ProjectParameters_stage2.json

+        "reduction_factor"                   : 0.5,
+        "increase_factor"                    : 2.0,
+        "desired_iterations"                 : 4,
+        "calculate_reactions"                : true,


No, I wanted to calculate as little as possible so put it to false in stage 1, but forgot stage 2. Made it more consistent now

rfaasse · 2025-02-21T12:45:49Z

...echanicsApplication/tests/deactivation_with_structural_element/ProjectParameters_stage2.json

+                "value"           : [0.0,0.0,0.0],
+                "table"           : [0,0,0]
+            }
+        },{


The reason is an oversight from my side, corrected it now, good catch!

rfaasse · 2025-02-21T12:46:22Z

applications/GeoMechanicsApplication/tests/test_deactivation_with_structural_element.py

+
+        file_pattern = os.path.join(project_path, "ProjectParameters_stage*.json")
+        stage_files = glob.glob(file_pattern)
+        print(stage_files)


rfaasse · 2025-02-21T12:57:21Z

...sApplication/tests/cpp_tests/custom_strategies/test_geomechanics_time_integration_scheme.cpp

@@ -53,8 +53,10 @@ class GeoMechanicsSchemeTester
        mModel.CreateModelPart("dummy", 2);
    }

-    template <class T>
-    void TestFunctionCalledOnComponent_IsCalledOnActiveAndInactiveComponents()
+    template <class T, typename AddComponentToModelPartLambda>


markelov208

Hi Richard, it looks very good for me.

avdg81

This looks good to me. Thanks for processing the review comments.

rfaasse added 8 commits February 20, 2025 09:05

Made initialize unconditional

bdd95e2

Added GiD generated test case (still needs to be cleaned up)

a61dd75

Created the test file and added it to the suite

1394026

Cleaned up the test files

45ffa33

Added a normal load to stage 2, such that we can see the effect of th…

600174c

…e truss

Added some expected results

4854fa9

Adjusted test case such that it's easier to understand the expected r…

06e0790

…esults

Added a readme for the test

18ea4ea

rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Feb 20, 2025

rfaasse self-assigned this Feb 20, 2025

rfaasse linked an issue Feb 20, 2025 that may be closed by this pull request

[GeoMechanicsApplication] Make sure the structural/interface elements used in the quay wall work with the geo reset displacement process #12868

Closed

rfaasse requested review from avdg81 and markelov208 February 20, 2025 13:11

rfaasse changed the title ~~[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in geo scheme~~ [GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme Feb 20, 2025

avdg81 reviewed Feb 21, 2025

View reviewed changes

Processing review comments, reformatting python test with black and r…

2a95bfb

…emoving SQ code smells

rfaasse commented Feb 21, 2025

View reviewed changes

markelov208 approved these changes Feb 21, 2025

View reviewed changes

avdg81 approved these changes Feb 21, 2025

View reviewed changes

rfaasse merged commit a14ec2f into master Feb 21, 2025
11 checks passed

rfaasse deleted the geo/12868-initialize-all-elements-in-geo-scheme branch February 21, 2025 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme #13152

[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme #13152

rfaasse commented Feb 20, 2025

avdg81 left a comment

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

avdg81 Feb 21, 2025

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

avdg81 Feb 21, 2025

rfaasse Feb 21, 2025

rfaasse left a comment

rfaasse Feb 21, 2025

rfaasse Feb 21, 2025

rfaasse Feb 21, 2025

rfaasse Feb 21, 2025

rfaasse Feb 21, 2025

markelov208 left a comment

avdg81 left a comment

	template <class T, typename AddComponentToModelPartLambda>
	template <typename T, typename AddComponentToModelPartCallable>

	KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveConditions,
	KRATOS_TEST_CASE_IN_SUITE(FunctionCalledOnElement_IsCalledOnActiveAndInactiveElements,

[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme #13152

[GeoMechanicsApplication] Initialize all entities (regardless of active/inactive status) in the geo scheme #13152

Conversation

rfaasse commented Feb 20, 2025

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment