Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRPC-71 Type-safe project accessors #106

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jun 19, 2024

Subsystem
Gradle

Problem Description

  • Project dependencies are strings literals
  • Project dependencies are long

Solution

  • Enable Gradle Type-safe project accessors
  • Remove kotlinx-rpc from module names, but preserve in artifact names

Example:
Old dependency notation:

implementation(project(":kotlinx-rpc-runtime:kotlinx-rpc-runtime-serialization:kotlinx-rpc-runtime-serialization-json"))

New dependency notation:

implementation(projects.runtime.runtimeSerialization.runtimeSerializationJson)

Mr3zee added 3 commits June 19, 2024 20:36
Removed `kotlinx-rpc-` prefix from Gradle module names. Modified artifactIds to contain this prefix
@Mr3zee Mr3zee self-assigned this Jun 19, 2024
@Mr3zee Mr3zee requested a review from e5l June 19, 2024 19:08
@Mr3zee Mr3zee merged commit 13a6613 into main Jun 20, 2024
3 checks passed
@Mr3zee Mr3zee deleted the KRPC-71-type-safe-project-accessors branch June 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants