Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JaCoCo ant-calls with programmatic calls of JaCoCo's classes #630

Closed
shanshin opened this issue Jun 10, 2024 · 1 comment · Fixed by #668
Closed

Replace JaCoCo ant-calls with programmatic calls of JaCoCo's classes #630

shanshin opened this issue Jun 10, 2024 · 1 comment · Fixed by #668
Assignees
@shanshin
Labels
Feature Feature request issue type S: ready for release Status: merged in the main branch

Comments

@shanshin
Copy link
Collaborator

shanshin commented Jun 10, 2024 •
edited
Loading

What is your use-case and why do you need this feature?
At the moment, ant-calls from the org.jacoco.ant dependency are used to work with JaCoCo.

This is a less reliable way to use dependencies, because we can only check the correctness of the code in runtime, we have to use the AntBuilder mechanism that we cannot control, unwanted code is executed, and it is also difficult to add new functionality to an existing.

Describe the solution you'd like
Changes:

  • calling the JaCoCo code inside Gradle workers with
  • using classes from org.jacoco.report to work with JaCoCo, e.g. RulesChecker for verification
  • analyze if its API changes for different versions of JaCoCo, then we will need to create your own module for each subsequent version with an individual dependency on the corresponding version of JaCoCo
  • suggestion: allow users to specify their own CoverageTool heirs so that their coverage tools can be implemented

Related issues, should be fixed by this changes: #606, #544
@shanshin shanshin added Feature Feature request issue type S: untriaged Status: issue reported but unprocessed labels Jun 10, 2024
@shanshin shanshin self-assigned this Jun 10, 2024
This was referenced Jun 10, 2024
Closed
Closed
@shanshin shanshin added S: postponed Status: work on the issue is not in the short term plans and removed S: untriaged Status: issue reported but unprocessed labels Jun 10, 2024
@shanshin shanshin mentioned this issue Aug 7, 2024
Closed
shanshin added a commit that referenced this issue Aug 7, 2024
@shanshin
Replaced JaCoCo ant-calls with programmatic calls of JaCoCo's classes
8cd1d87 
Resolves #630
Fixes #666
@shanshin shanshin mentioned this issue Aug 7, 2024
Merged
@shanshin shanshin reopened this Aug 28, 2024
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: postponed Status: work on the issue is not in the short term plans labels Aug 28, 2024
@shanshin
Copy link
Collaborator Author

shanshin commented Sep 3, 2024

Implemented in 0.9.0-RC

@shanshin shanshin closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Feature Feature request issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced JaCoCo ant-calls with programmatic calls of JaCoCo's classes Kotlin/kotlinx-kover
1 participant
@shanshin