Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koverPrintCoverage does not work when org.gradle.logging.level=warn #557

Closed
mgroth0 opened this issue Mar 2, 2024 · 2 comments · Fixed by #563
Closed

koverPrintCoverage does not work when org.gradle.logging.level=warn #557

mgroth0 opened this issue Mar 2, 2024 · 2 comments · Fixed by #563
Assignees
@shanshin
Labels
Bug Bug issue type S: ready for release Status: merged in the main branch

Comments

@mgroth0
Copy link

mgroth0 commented Mar 2, 2024

Describe the bug

When org.gradle.logging.level=warn, koverPrintCoverage does not produce any output.

Expected behavior

org.gradle.logging.level is used to control logging. Logging is a passive way to keep information on problems, errors, and just general information of a process. When org.gradle.logging.level=warn, we are saying that we only want warnings; we only want actionable information kept.

koverPrintCoverage is not passive logging. It is an optional task that is triggered manually when we want to see coverage information. It should not require that we set org.gradle.logging.level=lifecycle. Unlike all of the other information that is printed at the lifecycle log level, koverPrintCoverage is information that we have manually triggered to see.

Compare koverPrintCoverage with tasks. If org.gradle.logging.level=warn and we run ./gradlew tasks, we still see the printed output from the tasks task. koverPrintCoverage should work the same way.
@mgroth0 mgroth0 added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Mar 2, 2024
@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: untriaged Status: issue reported but unprocessed labels Mar 13, 2024
shanshin added a commit that referenced this issue Mar 13, 2024
@shanshin
Changed log level for print coverage task
b08ae58 
At the moment, the coverage was printed with the `lifecycle` level. However, if user limit the logs to the `--warn` level, the coverage stops printing.
Now coverage is printed with the quite level, thanks to this it is printed even with the limitations of `--warn` and `--quiet`.

Fixes #557
@shanshin shanshin mentioned this issue Mar 13, 2024
Merged
shanshin added a commit that referenced this issue Mar 26, 2024
@shanshin
Changed log level for print coverage task
9c3e772 
At the moment, the coverage was printed with the `lifecycle` level. However, if user limit the logs to the `--warn` level, the coverage stops printing.
Now coverage is printed with the quite level, thanks to this it is printed even with the limitations of `--warn` and `--quiet`.

Fixes #557
PR #563
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: in progress Status: implementing or design in process labels Mar 28, 2024
@shanshin shanshin reopened this Mar 28, 2024
@shanshin
Copy link
Collaborator

Fixed in 0.8.0-Beta2

@mgroth0
Copy link
Author

mgroth0 commented Mar 29, 2024

It works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed log level for print coverage task Kotlin/kotlinx-kover
2 participants
@shanshin @mgroth0