Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of jpeg files not supported by standard java ImageIO (#384) #404

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix loading of jpeg files not supported by standard java ImageIO (#384) #404

merged 1 commit into from
Jul 18, 2022

Conversation

ermolenkodev
Copy link
Collaborator

  • Add TwelveMonkeys ImageIO plugin

  • Add IO test with images from COCO 2017 test set, which failed to load using standard java ImageIO

@ermolenkodev ermolenkodev added the bug Something isn't working label Jul 12, 2022
@ermolenkodev ermolenkodev added this to the 0.5 milestone Jul 12, 2022
@ermolenkodev ermolenkodev self-assigned this Jul 12, 2022
@ermolenkodev
Copy link
Collaborator Author

I am a bit unsure if it is a good idea to introduce TwelveMonkeys ImageIO dependency for the KotlinDL. Maybe it's better to ask users to add it on the application side.

juliabeliaeva
juliabeliaeva approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@juliabeliaeva juliabeliaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also a bit unsure about the dependency, but we can add it now and remove it later if we don't like it. But I'd rather not add 70 images to the repository. Maybe adding just one or two test image would be enough for testing purposes?

@ermolenkodev
Copy link
Collaborator Author

Yes, fair enough. I will remove images with an identical encoding issues

@ermolenkodev
Fix loading of jpeg files not supported by standard java ImageIO (Kot…
b548620 
…lin#384)

* Add TwelveMonkeys ImageIO plugin

* Add IO test with images from COCO 2017 test set, which failed to load using standard java ImageIO
@ermolenkodev ermolenkodev merged commit c6685c1 into Kotlin:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliabeliaeva juliabeliaeva juliabeliaeva approved these changes

Assignees

@ermolenkodev ermolenkodev

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ermolenkodev @juliabeliaeva