Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GlobalMaxPool3D layer #130

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Add GlobalMaxPool3D layer #130

merged 4 commits into from
Jun 24, 2021

Conversation

mkaze
Copy link
Contributor

@mkaze mkaze commented Jun 16, 2021 •
edited
Loading

Resolves #117. This PR adds support for GlobalMaxPool3D layer.

  • Implement layer class.
  • Add unit tests for layer implementation.
  • Add support for importing models containing this layer from JSON config files
  • Add support for exporting models containing this layer to JSON config files

@mkaze mkaze changed the title [WIP] Add GlobalMaxPool3D layer Add GlobalMaxPool3D layer Jun 24, 2021
@mkaze
Copy link
Contributor Author

mkaze commented Jun 24, 2021

@zaleslaw This PR is ready to be reviewed.

@zaleslaw zaleslaw added the LGTM PR reviewed and is ready to merge label Jun 24, 2021
@zaleslaw
Copy link
Collaborator

@mkaze please, solve the merge conflict here

@mkaze
Copy link
Contributor Author

mkaze commented Jun 24, 2021

@zaleslaw I just fixed the merge conflict.

@zaleslaw zaleslaw merged commit bf09374 into Kotlin:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LGTM PR reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GlobalMaxPool3D layer
2 participants
@mkaze @zaleslaw