Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Jupyter version to Java 8 #200

Merged
merged 1 commit into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buildSrc/src/main/kotlin/Versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ object Versions {
const val groupID = "org.jetbrains.kotlinx.spark"
const val kotlin = "1.8.0"
const val jvmTarget = "8"
const val jupyterJvmTarget = "11"
const val jupyterJvmTarget = "8"

inline val spark get() = System.getProperty("spark") as String
inline val scala get() = System.getProperty("scala") as String
inline val sparkMinor get() = spark.substringBeforeLast('.')
inline val scalaCompat get() = scala.substringBeforeLast('.')

const val jupyter = "0.11.0-210"
const val jupyter = "0.12.0-32-1"
const val kotest = "5.5.4"
const val kotestTestContainers = "1.3.3"
const val dokka = "1.7.10"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class JupyterTests : ShouldSpec({
librariesScanner.addLibrariesFromClassLoader(
classLoader = currentClassLoader,
host = this,
notebook = notebook,
integrationTypeNameRules = listOf(
PatternNameAcceptanceRule(
acceptsFlag = false,
Expand Down Expand Up @@ -341,6 +342,7 @@ class JupyterStreamingTests : ShouldSpec({
librariesScanner.addLibrariesFromClassLoader(
classLoader = currentClassLoader,
host = this,
notebook = notebook,
integrationTypeNameRules = listOf(
PatternNameAcceptanceRule(
acceptsFlag = false,
Expand Down