Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loop) only use set_log_level API on http subsystem #9

Merged
merged 6 commits into from
Jan 30, 2023
Merged

fix(loop) only use set_log_level API on http subsystem #9

merged 6 commits into from
Jan 30, 2023

Conversation

gruceo
Copy link
Contributor

@gruceo gruceo commented Jan 18, 2023 •
edited by tyler-ball
Loading

@gruceo gruceo requested a review from ADD-SP January 18, 2023 15:20
@gruceo gruceo force-pushed the fix/http-module-dynamic-log-level branch 2 times, most recently from 21f1614 to 7eee507 Compare January 18, 2023 15:27
@gruceo gruceo force-pushed the fix/http-module-dynamic-log-level branch from 7eee507 to 158f553 Compare January 18, 2023 15:57
kikito
kikito reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add some tests to this change?

@gruceo gruceo force-pushed the fix/http-module-dynamic-log-level branch from 8f96e4c to 343fa4e Compare January 19, 2023 20:02
@gruceo gruceo requested a review from kikito January 19, 2023 20:03
@gruceo gruceo force-pushed the fix/http-module-dynamic-log-level branch from 343fa4e to 698b524 Compare January 23, 2023 13:09
@gruceo gruceo force-pushed the fix/http-module-dynamic-log-level branch from 698b524 to e6e8d1d Compare January 23, 2023 14:07
kikito
kikito approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem reasonable, it is a pity that the tests are so flaky.

I believe we need to make the build green at least once before we can merge this.

@kikito kikito self-requested a review January 24, 2023 18:03
@bungle bungle merged commit 60a0014 into main Jan 30, 2023
@bungle bungle deleted the fix/http-module-dynamic-log-level branch January 30, 2023 09:15
@chronolaw chronolaw mentioned this pull request Jan 30, 2023
Closed
ADD-SP added a commit that referenced this pull request Feb 8, 2023
@ADD-SP
Revert "fix(loop) only use set_log_level API on http subsystem (#9)"
6ac76f8 
This reverts commit 60a0014.
dndx pushed a commit that referenced this pull request Feb 8, 2023
@ADD-SP @dndx
Revert "fix(loop) only use set_log_level API on http subsystem (#9)"
baac2b9 
This reverts commit 60a0014.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

@kikito kikito Awaiting requested review from kikito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gruceo @kikito @bungle @ADD-SP