Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kdropdownitem): remove disabled class #1818

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix(kdropdownitem): remove disabled class #1818

merged 3 commits into from
Nov 3, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 3, 2023

Summary

Removes disabled class from .dropdown-item-trigger element in KDropdownItem

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this Nov 3, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 74cbf98
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6545619e3760b80008dae21a
😎 Deploy Preview https://deploy-preview-1818--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 74cbf98
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6545619e1e5cd30008d92ed0
😎 Deploy Preview https://deploy-preview-1818--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review November 3, 2023 20:39
@portikM portikM requested a review from a team as a code owner November 3, 2023 20:39
@portikM portikM enabled auto-merge (squash) November 3, 2023 20:40
@portikM portikM requested a review from adamdehaven November 3, 2023 21:10
adamdehaven
adamdehaven approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 44d5e2e into alpha Nov 3, 2023
@portikM portikM deleted the fix/kdropdownitem-remove-disabled-class branch November 3, 2023 21:15
kongponents-bot pushed a commit that referenced this pull request Nov 3, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.42 [skip ci]
c60a558 
# [9.0.0-alpha.42](v9.0.0-alpha.41...v9.0.0-alpha.42) (2023-11-03)

### Bug Fixes

* **kdropdownitem:** remove disabled class ([#1818](#1818)) ([44d5e2e](44d5e2e))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

Assignees

@portikM portikM

Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven