feat(clustering): revert removal of JSON-websocket support for config sync #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
changed the title
chronolaw
force-pushed
the
refactor/disable_clustering_wrpc
branch
from
faa0ebf to
b11380c
Compare
chronolaw
force-pushed
the
refactor/disable_clustering_wrpc
branch
2 times, most recently
from
3a4c160 to
a24289d
Compare
chronolaw
changed the title
|
I want to get @flrgh's opinion of this. My suggestion would be to not remove the wrpc files completely, but just disable their usage. Or is there a high confidence that wrpc is going away and never coming back? |
|
We'll need to come up with a game plan for this. I suspect that we can't fully remove wRPC in a single release, because it will break data planes running 3.1.0 and 3.1.1. We may have to support both protocols for a release cycle or two. |
chronolaw
added
the
pr/discussion
chronolaw
changed the title
chronolaw
force-pushed
the
refactor/disable_clustering_wrpc
branch
8 times, most recently
from
d9b9d81 to
630a4c1
Compare
chronolaw
force-pushed
the
refactor/disable_clustering_wrpc
branch
from
5fbd066 to
15fed0d
Compare
2 tasks
flrgh
approved these changes
Jan 6, 2023
dndx
pushed a commit
that referenced
this pull request
Jan 10, 2023
3 tasks
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…9921) Bumps [@kong/khcp-api-client](https://github.com/Kong/khcp/tree/HEAD/packages/khcp-api-client) from 0.1.2099 to 0.1.2111. - [Commits](https://github.com/Kong/khcp/commits/HEAD/packages/khcp-api-client) --- updated-dependencies: - dependency-name: "@kong/khcp-api-client" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to restore WebSocket protocol and remove wRPC protocol.
Revert PR #9740, update to PR #9823 #9769 , #9616 #9671 #9774.
There is still some code need to optimize, but I will leave them to another PR.
See KAG-210.
Related PRs: #8926 #8357
Checklist
Full changelog
control_plane.luawith newcompat.*compat.update_compatible_payloadto fit json+gzip