Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release/3.1.x] fix(ci): auth #9886

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mashapedeployment
Copy link
Contributor

Backport e557e96bd9d623fc625fda99fcd8051be501419b from #9883.

* fix(ci): necessary steps so we can authenticate against github

* fix(ci): explicitely set to false for arm64 assets

(cherry picked from commit e557e96bd9d623fc625fda99fcd8051be501419b)
@hutchic hutchic merged commit 414fa79 into release/3.1.x Dec 5, 2022
@hutchic hutchic deleted the backport-9883-to-release/3.1.x branch December 5, 2022 17:05
oowl pushed a commit that referenced this pull request Aug 15, 2024
… if it is `null` in database (#9886)

* fix(correlation-id): make `generator` a required field to prevent it from being set to `null` (#13439)

Some fields in the request body to admin api occasionally are specified as `json.null`.

In this PR, we add `required=true` to the schema of the field so that it can be auto-completed with the default when construction if it is `null` in database. It will become a mandatory field in KM.

(cherry picked from commit 166f465)

* add copyright header

---------

Co-authored-by: Robin Xiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants