fix(external-plugins): use lowercase for comparing string in error condition #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition When an instance_id of a plugin external changes, the plugin instance is resetted and retried in the bridge event loop again. This was failing and none was being retries due to a typo in the comparisson. This has been identified and tested with heavy traffic when the kong balancer is refreshed and reload into memory, it was not failing with low traffic.
|
16 hours load test without any failures @javierguerragiraldez , Now you can decide if do the fix just in 2.4 or port it to 2.3 as well |
javierguerragiraldez
approved these changes
May 13, 2021
|
I have seen in logs of nginx too many times (in high load) the folllowing annonying log: As this error is retried later and the request will succed an call the plugin, I would either change the log level to notice or even remove the error log. What do you think @javierguerragiraldez ? |
|
I agree that the error is annoying and makes it difficult to operate kong. Would it be possible to change it to level "notice" @javierguerragiraldez? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an instance_id of a plugin external changes, the plugin instance pretended to be reseted and retried in the bridge event loop again.
This was failing and none was being retried, making the call to the plugin did not happen; it was due to a typo in the comparisson.
This has been identified and tested with heavy traffic when the kong balancer is refreshed and reload into memoy cache; it was not failing with low traffic.
Issues resolved
Fix #7148