Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/plugins code to new db #3839

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Feat/plugins code to new db #3839

merged 4 commits into from
Oct 17, 2018

Conversation

kikito
Copy link
Member

@kikito kikito commented Oct 9, 2018 •
edited
Loading

Replaces usage of old-style DAO with new-style db in all plugins:

  • Noticed a bug in the ACL plugin cache invalidation code. Fixed here.
  • The main purpose of this task was replacing singletons.dao with calls to kong.db. I also replaced singletons.cache with kong.cache and singletons.configuration with kong.configuration.

hishamhm
hishamhm reviewed Oct 16, 2018
View reviewed changes
Copy link
Contributor

@hishamhm hishamhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of minor questions there — once those are clarified I think it's good to go.

@hishamhm hishamhm added pr/discussion This PR is being debated. Probably just a few details. and removed pr/please review labels Oct 16, 2018
@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from 3fa90a8 to af64679 Compare October 16, 2018 19:54
@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from af64679 to e136f6d Compare October 16, 2018 19:54
@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from e136f6d to abcc776 Compare October 16, 2018 20:15
@hishamhm hishamhm added pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) and removed pr/discussion This PR is being debated. Probably just a few details. labels Oct 17, 2018
hishamhm
hishamhm approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@hishamhm hishamhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hishamhm hishamhm merged commit dc2be94 into next Oct 17, 2018
@hishamhm hishamhm deleted the feat/plugins-code-to-new-db branch October 17, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamhm hishamhm hishamhm approved these changes

Assignees
No one assigned
Labels
pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kikito @hishamhm @thibaultcha