refactor(pluginserver): reset instance triggers invalidation #11819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently trigger invalidation events.
Also, `get_instance_id` uses plugin cache key to fetch instance id.
github-actions
bot
added
core/language/go
core/proxy
core/language/python
core/language/js
labels
StarlightIbuki
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
This should work. But as for the EE PR, we have the same improvements that could be done:
seq is not used so could be removed.
Also, a note to myself: we could use a much simpler model, which does not require maintaining an instance list:
- Every worker starts and maintains its instance of plugin server binary;
- All plugin instances (for a single worker) run on the same process. It means no thread/go routine is needed
This is possible as we do not maintain states for plugin instance.
tzssangglass
reviewed
Nov 2, 2023
Comment on lines
+410
to
+413
| if err_lowered == "not ready" then | ||
| self.reset_instance(plugin_name, conf) | ||
| end | ||
| if str_find(err_lowered, "no plugin instance") |
There was a problem hiding this comment.
need to exit when err_lowered appears here?
jschmid1
approved these changes
Nov 7, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fixes https://github.com/Kong/kong-ee/pull/6417.
KAG-2859.