chore(deps): bump lua-ffi-zlib to 0.6 and remove zlib dev packages from artifact dependency #11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to be a single lua file, whatabout just adding it to Kong repo? Or do we absolutely need to keep the module name the same? It feels like it is only used in couple of places. Also I think there has been never updates to this library since it was included in Kong. Or perhaps just once. |
|
@bungle I also opened a PR to upstream. How do you feel about just bump it if it got merged in upstream vs. bundling it? |
fffonion
changed the title
VicYP
approved these changes
Aug 18, 2023
|
@windmgc Merge. |
windmgc
approved these changes
Aug 18, 2023
oowl
approved these changes
Aug 18, 2023
|
needs cherrypick to EE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlib1g-dev
Requires Kong/lua-ffi-zlib#1
Summary
Checklist
Full changelog
Issue reference
Fix KAG-2241