-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): don't fail on route with multiple paths #11158
fix(router): don't fail on route with multiple paths #11158
Conversation
6223008
to
6245e6e
Compare
In `traditional_compatible` mode, the router would fail to work if a route with multiple paths but no service would be created. Fixes KAG-1961
6245e6e
to
f5ad223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need a backport to older than 3.3?
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.3.x release/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.3.x
# Create a new branch
git switch --create backport-11158-to-release/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0bd002f3f573b5eff821ff6cf85278defc2df21
# Push it to GitHub
git push --set-upstream origin backport-11158-to-release/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.3.x Then, create a pull request where the |
No, the change that caused this issue was introduced in 3.3. |
Summary
In
traditional_compatible
mode, the router would fail to work if a route with multiple paths but no service would be created.Checklist
Issue reference
Fixes KAG-1961