Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): enable flavor expressions in stream subsystem #11071

Merged
merged 87 commits into from
Jul 25, 2023
Merged

feat(router): enable flavor expressions in stream subsystem #11071

merged 87 commits into from
Jul 25, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jun 15, 2023 •
edited
Loading

Summary

KAG-1491

related PR : Kong/atc-router#82

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch 2 times, most recently from 2d13757 to e0d8cbd Compare June 19, 2023 00:40
@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch 2 times, most recently from 042a48d to 493ce12 Compare June 27, 2023 09:03
@chronolaw chronolaw mentioned this pull request Jul 4, 2023
Merged
@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch 2 times, most recently from 23ee947 to f08e5ca Compare July 7, 2023 03:15
@chronolaw chronolaw marked this pull request as ready for review July 7, 2023 03:36
@chronolaw chronolaw changed the title feat(router): enable flavor expressions in stream subsystem (WIP) feat(router): enable flavor expressions in stream subsystem Jul 7, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 7, 2023
@chronolaw chronolaw requested a review from dndx July 7, 2023 08:03
dndx
dndx reviewed Jul 10, 2023
View reviewed changes
.requirements Outdated Show resolved Hide resolved
@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch 2 times, most recently from 2f537c1 to be88f40 Compare July 10, 2023 07:01
@chronolaw chronolaw mentioned this pull request Jul 11, 2023
Closed
3 tasks
@randmonkey randmonkey mentioned this pull request Jul 11, 2023
Closed
4 tasks
@dndx dndx requested a review from ADD-SP July 11, 2023 17:40
ADD-SP
ADD-SP requested changes Jul 12, 2023
View reviewed changes
kong/router/utils.lua Outdated Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch from f9ef8b4 to 204bea8 Compare July 17, 2023 06:56
@dndx dndx force-pushed the feat/support_expression_in_stream branch from 424e284 to ae82bbf Compare July 19, 2023 14:22
@chronolaw chronolaw force-pushed the feat/support_expression_in_stream branch from ae82bbf to 681969e Compare July 21, 2023 05:40
@chronolaw chronolaw added this to the 3.4.0 milestone Jul 24, 2023
randmonkey
randmonkey reviewed Jul 24, 2023
View reviewed changes
kong/router/atc.lua Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
@randmonkey
Copy link
Contributor

Can we add some unit tests for specially for expression router?

StarlightIbuki
StarlightIbuki reviewed Jul 24, 2023
View reviewed changes
kong/router/atc.lua Show resolved Hide resolved
kong/router/atc.lua Show resolved Hide resolved
kong/router/atc.lua Show resolved Hide resolved
kong/router/atc.lua Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
kong/router/compat.lua Outdated Show resolved Hide resolved
.requirements Show resolved Hide resolved
kong/router/expressions.lua Show resolved Hide resolved
@chronolaw
Copy link
Contributor Author

Can we add some unit tests for specially for expression router?

We have enabled unit tests for all flavors in spec/01-unit/08-router_spec.lua.

StarlightIbuki
StarlightIbuki reviewed Jul 24, 2023
View reviewed changes
kong/router/utils.lua Outdated Show resolved Hide resolved
spec/01-unit/08-router_spec.lua Show resolved Hide resolved
spec/02-integration/05-proxy/01-proxy_spec.lua Show resolved Hide resolved
StarlightIbuki
StarlightIbuki approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve given the CI is green.

@rodman10 rodman10 mentioned this pull request Jul 24, 2023
Merged
1 task
@guanlan guanlan merged commit 5c7a7b8 into master Jul 25, 2023
@guanlan guanlan deleted the feat/support_expression_in_stream branch July 25, 2023 02:18
@team-gateway-bot team-gateway-bot mentioned this pull request Jul 25, 2023
Merged
@chronolaw chronolaw mentioned this pull request Jul 25, 2023
Merged
3 tasks
flrgh pushed a commit that referenced this pull request Jul 25, 2023
@chronolaw @flrgh
feat(router): enable flavor expressions in stream subsystem (#11071)
cfe6341 
(cherry picked from commit 5c7a7b8)
windmgc pushed a commit that referenced this pull request Jul 26, 2023
@chronolaw @windmgc
feat(router): enable flavor expressions in stream subsystem (#11071)
60ea28c 
(cherry picked from commit 5c7a7b8)
fffonion pushed a commit that referenced this pull request Jul 31, 2023
@chronolaw
style(router): rename buffer_append to expression_append (#11277)
cbcddf2 
Apply the suggestion in #11071 (comment).

KAG-2148
@chronolaw chronolaw mentioned this pull request Aug 4, 2023
Merged
2 tasks
@kikito kikito mentioned this pull request Aug 9, 2023
Merged
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx left review comments

@randmonkey randmonkey randmonkey left review comments

@ADD-SP ADD-SP ADD-SP approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

Assignees

@chronolaw chronolaw

Labels
changelog size/XL
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chronolaw @randmonkey @dndx @ADD-SP @StarlightIbuki @guanlan