Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-transformer): honor untrusted_lua configuration values #10327

Merged
merged 2 commits into from
Mar 30, 2023
Merged

feat(request-transformer): honor untrusted_lua configuration values #10327

merged 2 commits into from
Mar 30, 2023

Conversation

samugi
Copy link
Member

@samugi samugi commented Feb 20, 2023 •
edited
Loading

Summary

This PR enables support for the following configuration parameters and values in the request-transformer plugin:

  • untrusted_lua = "on", "off", "sandbox"
  • untrusted_lua_sandbox_requires
  • untrusted_lua_sandbox_environment

Checklist

Full changelog

  • [Implement ...]

KAG-168
KAG-169

@samugi samugi force-pushed the feat/kag-168-untrusted-lua branch 2 times, most recently from dda7870 to 2c80822 Compare February 20, 2023 16:17
@samugi samugi force-pushed the feat/kag-168-untrusted-lua branch 3 times, most recently from f332fe7 to ae6f700 Compare February 27, 2023 11:31
@samugi samugi force-pushed the feat/kag-168-untrusted-lua branch 2 times, most recently from 2265596 to 547355d Compare March 10, 2023 15:45
samugi added 2 commits March 23, 2023 16:46
@samugi
feat(request-transformer): untrusted_lua sandbox
0f3798b 
Return error when untrusted_lua is 'off' and lua expressions are
detected
Execute only sandbox-allowed code when untrusted_lua = 'on'
Execute with no restriction when untrusted_lua = 'sandbox'
@samugi
chore(*): changelog
086ce4f
@samugi samugi force-pushed the feat/kag-168-untrusted-lua branch from 547355d to 086ce4f Compare March 23, 2023 15:55
@kikito kikito merged commit 7eadfe6 into master Mar 30, 2023
@kikito kikito deleted the feat/kag-168-untrusted-lua branch March 30, 2023 21:35
@kikito
Copy link
Member

kikito commented Apr 24, 2023

@samugi this PR needs an update in the request-transformer docs page. Our page for request-transformer does not have a changelog at the end yet, but use the one in request-transformer-advanced as an example.

@samugi samugi mentioned this pull request Apr 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx left review comments

@kikito kikito kikito approved these changes

Assignees

@samugi samugi

Labels
changelog plugins/request-transformer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samugi @kikito @dndx