Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opentelemetry): http.uri should be full path #10069

Merged
merged 3 commits into from
Jan 6, 2023
Merged

fix(opentelemetry): http.uri should be full path #10069

merged 3 commits into from
Jan 6, 2023

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Jan 5, 2023 •
edited
Loading

@StarlightIbuki
Copy link
Contributor Author

@mayocream Seems like we do not even have a test for this field?

@mayocream
Copy link
Contributor

@mayocream Seems like we do not even have a test for this field?

Let's add one instead

colinh-kong
colinh-kong approved these changes Jan 5, 2023
View reviewed changes
Copy link

@colinh-kong colinh-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending a test

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 6, 2023
@dndx
Copy link
Member

dndx commented Jan 6, 2023

@StarlightIbuki This needs rebasing. Also is there a Jira ticket number for this fix?

@StarlightIbuki
Copy link
Contributor Author

@StarlightIbuki This needs rebasing. Also is there a Jira ticket number for this fix?

Conflict solved.

@dndx dndx merged commit 93a4bbf into master Jan 6, 2023
@dndx dndx deleted the fix/optl_uri branch January 6, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@colinh-kong colinh-kong colinh-kong approved these changes

@mayocream mayocream Awaiting requested review from mayocream

Assignees
No one assigned
Labels
changelog core/tracing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarlightIbuki @mayocream @dndx @colinh-kong