Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Feature request: Set dynamic tags through request headers #97

Closed
secat opened this issue Oct 1, 2020 · 2 comments
Closed

Feature request: Set dynamic tags through request headers #97

secat opened this issue Oct 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@secat
Copy link

secat commented Oct 1, 2020

We would like to be able to inject dynamically tags based on the request headers, i.e. be able to configure the plugin to select pre-defined request headers and inject them as tags inside spans.

Does this sound to you as a neat feature?

NOTE It will probably look like the following PR: feat(handler) static tags #84
@jcchavezs
Copy link
Contributor

This is definitively a nice feature to have. We have in some of the zipkin tracers.

@kikito kikito added the enhancement New feature or request label Nov 11, 2020
kikito added a commit that referenced this issue Feb 10, 2021
@kikito
feat(handler) allow setting trace tags via req header
7b0eb53 
Implements #97
@kikito kikito mentioned this issue Feb 10, 2021
Merged
kikito added a commit that referenced this issue Feb 10, 2021
@kikito
feat(handler) allow setting trace tags via req header
dffd1e0 
Implements #97
@kikito
Copy link
Member

kikito commented Feb 15, 2021

Implemented in #102

@kikito kikito closed this as completed Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kikito @jcchavezs @secat