fix: #6334 updating requestgroup caused render error #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
force-pushed
the
fix/issue-6334-render-error-update-reqgroup
branch
from
7cc995b to
8b365e8
Compare
|
We need to standardise on a update request convention. Thanks for the fix |
jackkav
approved these changes
Aug 21, 2023
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* fix: Kong#6334 updating requestgroup caused render error * add test * fix rename * redirect on move --------- Co-authored-by: jackkav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed issue #6334 where a error was thrown when updating a Request Folder via its Settings.
Closes #6334
The way we were calling update request group (e.g. when renaming or moving a request folder, or changing its description) wasn't properly setup. This PR fixed that. Also added a test.
Pending problems