Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target for Reqwest library for Rust #242

Closed
wants to merge 3 commits into from
Closed

Add target for Reqwest library for Rust #242

wants to merge 3 commits into from

Conversation

uWynell
Copy link

@uWynell uWynell commented Feb 2, 2022

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the necessary test fixtures for this new target?

@@ -1,5 +1,5 @@
{
"version": "2.0.0",
"version": "2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need to do this in a PR, when they publish a release they'll handle this.

@uWynell uWynell closed this Feb 23, 2022
@dimitropoulos
Copy link
Contributor

@uWynell not sure why this closed, but just wanted to point your attention to #248 which may be merging soon. one of the things I hope to do after launch is get a rust target in. if you have any interest in continuing this work please let me know!

@dimitropoulos dimitropoulos mentioned this pull request Apr 14, 2022
@uWynell
Copy link
Author

uWynell commented Apr 24, 2022

@dimitropoulos Yep, I'd like to implmenet a target for reqwest similarly to other targets in #248. If it's not urgent, I will do it in about a week. Or I can hurry up, if necessary.
P.S. I don't remember myself why I closed this pull :\

@dimitropoulos
Copy link
Contributor

cool, lemme know how it goes! Just merged #248 so you should be good to start on it whenever you feel like or have time :)

@SKPG-Tech
Copy link

Any plans on continuing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants