chore(*) fix lints #421
Closed
chore(*) fix lints #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discard a bunch of unused parameters and rename a poorly-capitalized argument.
flrgh
approved these changes
Mar 25, 2024
pmalek
requested changes
Mar 29, 2024
| @@ -492,7 +492,7 @@ func TestRoutesValidationTraditionalCompatible(T *testing.T) { | |||
| msgStartWith: "schema violation (paths.2: invalid regex:", | |||
| }, | |||
| } { | |||
| T.Run(tC.name, func(t *testing.T) { | |||
There was a problem hiding this comment.
We should use that t in assertions below to fail the subtest and not the whole suite
|
AFAICT 241dbb8 includes all of what was originally here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking dependabot upgrades after a linter upgrade, e.g. https://github.com/Kong/go-kong/actions/runs/8045072066/job/21980638584?pr=420
Discard a bunch of unused parameters and rename a poorly-capitalized argument.
Could probably discard most of the args entirely, but 🤷 they're mostly test objects in test functions, which are kinda standard-ish, so I kept the placeholder around.