fix: allow plugins to be scoped to multiple entities when on consumer… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/plugin-scoping-to-cg-and-more
branch
2 times, most recently
from
1f1263c to
dcb47dd
Compare
GGabriele
force-pushed
the
fix/plugin-scoping-to-cg-and-more
branch
from
dcb47dd to
fff94b2
Compare
GGabriele
force-pushed
the
fix/plugin-scoping-to-cg-and-more
branch
from
fff94b2 to
174073c
Compare
rainest
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
The keepalive_pool_size changes look a bit 🤔 given that it's apparently not a schema violation and we're not actually using Redis in those configs, but I suppose the rest looks fine and changing (unused) test config can't obviously hurt anything 🤷
Is that somehow necessary for 3.4+ compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-groups
Summary
SUMMARY_GOES_HERE
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing