-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed dql routes format to show dict for service #187
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 28.15% 28.17% +0.02%
==========================================
Files 109 109
Lines 17190 17227 +37
==========================================
+ Hits 4839 4854 +15
- Misses 11830 11852 +22
Partials 521 521 ☔ View full report in Codecov by Sentry. |
Before this change, the yaml format for custom_entities was as such:
After this change, the format is as such:
|
deck gateway dump would render the following:
|
assert.ErrorContains(t, err, "service field should be a map") | ||
}) | ||
|
||
t.Run("create degraphql route - fails if service reference is not an object", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prashansa-K this test is repeated? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! I will clean this up.
Summary
While creating a degraphql-route using deck, we were specifying
service field as a string. This is different than how deck usually
handles references. So, inorder to comply with the current deck
format, we are changing the service reference to a dict.
Full changelog
Issues resolved
Pre-req for Kong/deck#1505
Testing