Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix condition for getting Kong license #819

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 28, 2024

What this PR does / why we need it:

Attempts to fix https://github.com/Kong/gateway-operator/actions/runs/11557658624.

TIL: you cannot use secrets in a step if condition: actions/runner#520

@czeslavo czeslavo marked this pull request as ready for review October 28, 2024 16:00
@czeslavo czeslavo requested a review from a team as a code owner October 28, 2024 16:00
@czeslavo czeslavo added this to the KGO v1.4.x milestone Oct 28, 2024
@czeslavo czeslavo self-assigned this Oct 28, 2024
@czeslavo czeslavo marked this pull request as draft October 28, 2024 16:07
@czeslavo czeslavo force-pushed the fix-release-reusable branch from a93de4b to 7e39d43 Compare October 28, 2024 16:13
@czeslavo czeslavo changed the title chore(ci): change secret extracting notation chore(ci): fix condition for getting Kong license Oct 28, 2024
@czeslavo czeslavo marked this pull request as ready for review October 28, 2024 16:13
@czeslavo czeslavo merged commit c145915 into main Oct 28, 2024
21 checks passed
@czeslavo czeslavo deleted the fix-release-reusable branch October 28, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants