Fix deck gateway apply
#1508
Merged
Fix deck gateway apply
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheap
force-pushed
the
fix-apply-command
branch
from
a24312d to
e56ac2f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
+ Coverage 29.22% 29.28% +0.05%
==========================================
Files 62 62
Lines 6666 6639 -27
==========================================
- Hits 1948 1944 -4
+ Misses 4580 4556 -24
- Partials 138 139 +1 ☔ View full report in Codecov by Sentry. |
mheap
force-pushed
the
fix-apply-command
branch
2 times, most recently
from
d2fe4f1 to
9aded15
Compare
pmalek
reviewed
Jan 28, 2025
mheap
force-pushed
the
fix-apply-command
branch
from
1529774 to
120df79
Compare
mheap
force-pushed
the
fix-apply-command
branch
2 times, most recently
from
580a39c to
2d486c0
Compare
Co-authored-by: Patryk Małek <[email protected]>
mheap
force-pushed
the
fix-apply-command
branch
from
2d486c0 to
4de5886
Compare
|
It looks as though the changelog is added at release time based on #1502 Merging, and can issue a followup PR if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deck gateway applycommand added in v1.43.0 added additional HTTP calls to discover which functions are enabled. This does not work well when using an RBAC user with restricted permissions.This change removes those additional checks and delegates the lookup of foreign keys for partial applications to
go-database-reconciler