Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quoted type constraints #1412

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove quoted type constraints #1412

merged 1 commit into from
Oct 10, 2024

Conversation

battlebyte
Copy link
Collaborator

Type constraints in quotes was required in Terraform 0.11 and earlier, but that form is now deprecated and will be removed in a future version of Terraform. For example:

variable "control_plane_id" {
  type = "string"
  default = "YOUR_CONTROL_PLANE_ID"
}

should be

variable "control_plane_id" {
  type = string
  default = "YOUR_CONTROL_PLANE_ID"
}

if the quotes are present, an error is shown during terraform apply.

Type constraints in quotes was required in Terraform 0.11 and earlier, but that form is now deprecated and will be removed in a future version of Terraform. For example:

variable "control_plane_id" {
  type = "string"
  default = "YOUR_CONTROL_PLANE_ID"
}
should be

variable "control_plane_id" {
  type = string
  default = "YOUR_CONTROL_PLANE_ID"
}
if the quotes are present, an error is shown during terraform apply.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.14%. Comparing base (cd165de) to head (e78ee36).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   29.14%   29.14%           
=======================================
  Files          59       59           
  Lines        5215     5215           
=======================================
  Hits         1520     1520           
  Misses       3587     3587           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@battlebyte battlebyte requested a review from Prashansa-K October 7, 2024 07:32
@Prashansa-K Prashansa-K merged commit 5f84270 into main Oct 10, 2024
19 checks passed
@Prashansa-K Prashansa-K deleted the kong2tf-quoted-type branch October 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants