Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when a mandatory flag is missing #1429

Closed
mheap opened this issue Oct 29, 2024 · 0 comments
Closed

Improved error message when a mandatory flag is missing #1429

mheap opened this issue Oct 29, 2024 · 0 comments
Assignees

Comments

@mheap
Copy link
Member

mheap commented Oct 29, 2024

When a mandatory CLI flag is missing, the error message is not helpful:

$ deck file convert --from kong-gateway-2.x
Error: invalid format: ''

It would help to add the name of the field, e.g.

Error: invalid value '' found for the 'to' flag
harshadixit12 added a commit that referenced this issue Jan 9, 2025
…onvert (#1429)

When mandatory flags for file convert are missing, the error message is not helpful. In this commit, we have added additional validation to communicate more details in the message.
harshadixit12 added a commit that referenced this issue Jan 10, 2025
…onvert (#1429)

When mandatory flags for file convert are missing, the error message is not helpful. In this commit, we have added additional validation to communicate more details in the message.
harshadixit12 added a commit that referenced this issue Jan 10, 2025
…onvert (#1429)

When mandatory flags for file convert are missing, the error message is not helpful. In this commit, we have added additional validation to communicate more details in the message.
harshadixit12 added a commit that referenced this issue Jan 15, 2025
…onvert (#1429) (#1487)

* fix: improve error messaging when mandatory flag is missing in file convert (#1429)

When mandatory flags for file convert are missing, the error message is not helpful. In this commit, we have added additional validation to communicate more details in the message.

* add a reusable validation function for strings

* assert converted file contents and address review feedback

* limit file convert tests to yaml format for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants