Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset -> exposes + SMSZB-120 updates #2895

Merged
merged 13 commits into from
Aug 16, 2021
Merged

Preset -> exposes + SMSZB-120 updates #2895

merged 13 commits into from
Aug 16, 2021

Conversation

TheStigh
Copy link
Contributor

@TheStigh TheStigh commented Aug 11, 2021

Hi Koen,

With the upcoming Develco SIRZB-110, I've implemented Squawk. Please accept this PR for presets (I've tested this locally using composite).

Also, I changed SMSZB-120 as you've added exposes e.warning(), I removed it again since this device do not support editing anything. There are only one result - a fire alarm. I'm keeping the tz.warning for backwards compatibility for other users.

I renamed fz.smszb120_fw to fz.develco_fw as this are identical for all Develco devices, updated SMSZB-120 device with this change.

@TheStigh TheStigh changed the title Preset for upcoming Squawk converter Preset -> exposes + SMSZB-120 updates Aug 11, 2021
@TheStigh
Copy link
Contributor Author

TheStigh commented Aug 15, 2021

So, added fz.ias_siren, updated tz.warning_simple, added SIRZB-110 device, updated Climax SRAC-23B-ZBSR.

@Koenkk Koenkk merged commit c120a92 into Koenkk:master Aug 16, 2021
@Koenkk
Copy link
Owner

Koenkk commented Aug 16, 2021

Thanks!

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021

Can we have these changes also for the develco fire detector HESZB-120? The datasheet is exacltly the same as the smoke detector...

@TheStigh
Copy link
Contributor Author

Can we have these changes also for the develco fire detector HESZB-120? The datasheet is exacltly the same as the smoke detector...

I can add it but I can't test it as I don't have such device.
Are you able to test if I write the local converter for you?
You need to be a bit familiar with configuring Z2M.

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021 via email

@TheStigh
Copy link
Contributor Author

Then you can just do the PR yourself :)

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021 via email

@TheStigh
Copy link
Contributor Author

I mean the extra changes regarding ota... I only tested the converter (develco.js).. What other changes are needed?

You only want the OTA for the device? I cannot provide it as I don't have access to the firmware for that particular device. Without the access to the firmware, we cannot activate OTA for the device.

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021 via email

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021

but you stated:
I renamed fz.smszb120_fw to fz.develco_fw as this are identical for all Develco devices, updated SMSZB-120 device with this change

Should i try and update the firmware from zigbee2mqtt webgui?

@TheStigh
Copy link
Contributor Author

fz.develco_fw are the converter to read out the firmware version from any Develco product as this are not reported by the device on regular interview.

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 22, 2021

So it's safe to update?
querying the ota:
Read result of 'genOta': {"upgradeServerId":"0x00212effff04fec3","currentFileVersion":197657,"imageUpgradeStatus":1,"manufacturerId":4117}

@TheStigh
Copy link
Contributor Author

Update what? HESZB-120? That is not the same product and it should not update using the firmware of SMSZB-120. If it says up gradable, I will not take responsibility of saying OK.

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 23, 2021 via email

@TheStigh
Copy link
Contributor Author

No... manufacturer id are what it says - the manufacturer id

@mamrai1
Copy link
Contributor

mamrai1 commented Aug 23, 2021 via email

@TheStigh
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants